On Thu, May 30, 2024 at 02:16:46PM +0800, Weiwen Hu wrote: > + switch (nvme_sc & 0x7ff) { Can you use the opportunity to add a NVME_SC_MASK symbolic name for the magic 0x7ff? We should have done this earlier with already 5 occurrences, but better now than never. Otherwise this looks good to me.