[PATCHv3 0/3] nvme: enable retries for authentication commands
Chaitanya Kulkarni
chaitanyak at nvidia.com
Mon Jan 29 03:12:41 PST 2024
On 1/27/24 01:37, hare at kernel.org wrote:
> From: Hannes Reinecke <hare at suse.de>
>
> Hi all,
>
> authentitication commands are normal NVMe commands, and should be retried
> if returned with a status where the DNR bit is not set. But instead of
> having the caller retry the commaand this patchset enables the function
> __nvme_submit_sync_cmd() to not set the FASTFAIL flag in the request,
> thereby making the functionality generally available.
>
> As usual, comments and reviews are welcome.
>
> Hannes Reinecke (3):
> nvme-auth: open-code single-use macros
> nvme: simplify __nvme_submit_sync_cmd() calling conventions
> nvme: enable retries for authentication commands
>
> drivers/nvme/host/auth.c | 17 ++++++++---------
> drivers/nvme/host/core.c | 21 ++++++++++++++-------
> drivers/nvme/host/fabrics.c | 18 +++++++++++-------
> drivers/nvme/host/nvme.h | 19 +++++++++++++++++--
> 4 files changed, 50 insertions(+), 25 deletions(-)
>
this version addresses comments posted on V2, looks good to me, it'd be
great
if we can somehow trigger retries through blktests ..
Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
-ck
More information about the Linux-nvme
mailing list