Question about bool in __nvme_submit_sync_cmd

Nicky Chorley ndchorley at gmail.com
Sat Jan 27 04:25:17 PST 2024


Hi folks,

I noticed that in nvme/core/host.c, __nvme_submit_sync_cmd takes an
int parameter at_head. That's passed down to nvme_execute_rq, where
the parameter is declared as a bool (and looks like it has been since
that function was introduced in commit ae5e6886b4f8 ("nvme: use return
value from blk_execute_rq()").

Should the at_head parameter of __nvme_submit_sync_cmd (and I guess
nvme_submit_sync_cmd) be changed to a bool, or is there a reason to
keep it as int?

Thanks,

Nicky



More information about the Linux-nvme mailing list