[PATCH] nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE

Sagi Grimberg sagi at grimberg.me
Mon Aug 19 07:23:21 PDT 2024




On 19/08/2024 16:50, Hannes Reinecke wrote:
> On 8/19/24 15:18, Sagi Grimberg wrote:
>>
>>
>>
>> On 19/08/2024 15:27, Hannes Reinecke wrote:
>>> NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not
>>> 'struct nvme_ns'.
>>
>> Hannes, what is the phenomenon here? Is anything leaked or functionally
>> broken?
>>
>> The patch looks good, but please explain if this is caught from code 
>> inspection
>> or a real issue that surfaced.
>>
>> For the patch itself,
>> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
>
> We've seen the issue popping up during repeated map/unmap operations
> with reusing NSIDs; occasionally we would end up with stale multipath
> namespaces and non-existing generic devices.

Great, please reword the change log to explain _what_ is fixed in the patch
title and how you fix it in the patch body.



More information about the Linux-nvme mailing list