[PATCH] nvme-multipath: fix typo clearing NVME_NSHEAD_DISK_LIVE

Hannes Reinecke hare at suse.de
Mon Aug 19 06:50:13 PDT 2024


On 8/19/24 15:18, Sagi Grimberg wrote:
> 
> 
> 
> On 19/08/2024 15:27, Hannes Reinecke wrote:
>> NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_nshead', not
>> 'struct nvme_ns'.
> 
> Hannes, what is the phenomenon here? Is anything leaked or functionally
> broken?
> 
> The patch looks good, but please explain if this is caught from code 
> inspection
> or a real issue that surfaced.
> 
> For the patch itself,
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

We've seen the issue popping up during repeated map/unmap operations
with reusing NSIDs; occasionally we would end up with stale multipath
namespaces and non-existing generic devices.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich




More information about the Linux-nvme mailing list