[PATCH] nvme: print disposition on err req completion

Sagi Grimberg sagi at grimberg.me
Thu Jun 8 00:02:12 PDT 2023


>>> Hmm, not sure this is the right way to approach it.  I'd rather
>>> redo how the trace points work by having a class and the ondividual
>>> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.
>>
>> :)
>>
>> This was the original proposal (posted as a question to the list),
>> and I proposed this approach. You don't like it?
> 
>   1) the different dispostitions are really very different events,
>      lumping them up does make tracing harder because you need to
>      manually filter every time

True.

>   2) I really don't like exposing the disposition enum outside of core.c

Don't think its much of an issue. But in any event I agree with having
different classes for easier tracing.



More information about the Linux-nvme mailing list