[PATCH] nvme: print disposition on err req completion

Christoph Hellwig hch at lst.de
Wed Jun 7 22:53:20 PDT 2023


On Wed, Jun 07, 2023 at 06:08:16PM +0300, Sagi Grimberg wrote:
>> Hmm, not sure this is the right way to approach it.  I'd rather
>> redo how the trace points work by having a class and the ondividual
>> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.
>
> :)
>
> This was the original proposal (posted as a question to the list),
> and I proposed this approach. You don't like it?

 1) the different dispostitions are really very different events,
    lumping them up does make tracing harder because you need to
    manually filter every time
 2) I really don't like exposing the disposition enum outside of core.c



More information about the Linux-nvme mailing list