[PATCH] nvme: print disposition on err req completion

Sagi Grimberg sagi at grimberg.me
Wed Jun 7 08:08:16 PDT 2023


>> Currently we don't print disposition in the request completion path
>> in nvme_complete_rq() tracepoint, so when request fails it is not
>> straight forward to understand the diposition making it hard to debug
>> the problems in the field.
>>
>> Update nvme_complete_rq() tracepoint to print the disposition when
>> request fails, since disposition value will always be 0 when request
>> status = 0.
> 
> Hmm, not sure this is the right way to approach it.  I'd rather
> redo how the trace points work by having a class and the ondividual
> tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.

:)

This was the original proposal (posted as a question to the list),
and I proposed this approach. You don't like it?

I kinda like the explicit disposition output.



More information about the Linux-nvme mailing list