[PATCH] nvme: print disposition on err req completion

Christoph Hellwig hch at lst.de
Tue Jun 6 22:00:59 PDT 2023


On Sun, Jun 04, 2023 at 11:49:33PM -0700, Chaitanya Kulkarni wrote:
> Currently we don't print disposition in the request completion path
> in nvme_complete_rq() tracepoint, so when request fails it is not
> straight forward to understand the diposition making it hard to debug
> the problems in the field.
> 
> Update nvme_complete_rq() tracepoint to print the disposition when
> request fails, since disposition value will always be 0 when request
> status = 0.

Hmm, not sure this is the right way to approach it.  I'd rather
redo how the trace points work by having a class and the ondividual
tracepoints in nvme_end_req/nvme_retry_req/nvme_failover_req.




More information about the Linux-nvme mailing list