[PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code
Bart Van Assche
bvanassche at acm.org
Mon Aug 28 08:14:09 PDT 2023
On 8/22/23 01:38, Daniel Wagner wrote:
> + while [[ $# -gt 0 ]]; do
> + case $1 in
> + --blkdev)
> + blkdev_type="$2"
> + shift 2
> + ;;
> + --ctrlkey)
> + ctrlkey="$2"
> + shift 2
> + ;;
> + --hostkey)
> + hostkey="$2"
> + shift 2
> + ;;
> + *)
> + shift
> + ;;
> + esac
> + done
So all arguments that are not recognized are ignored? That will
make debugging typo's harder than necessary. Shouldn't this function
complain if an unrecognized argument is encountered?
Thanks,
Bart.
More information about the Linux-nvme
mailing list