[PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

Shinichiro Kawasaki shinichiro.kawasaki at wdc.com
Sun Aug 27 21:17:14 PDT 2023


On Aug 22, 2023 / 10:38, Daniel Wagner wrote:
[...]
> diff --git a/tests/nvme/015 b/tests/nvme/015
> index bc04e39c628c..b418d785ab27 100755
> --- a/tests/nvme/015
> +++ b/tests/nvme/015
> @@ -20,19 +20,12 @@ test() {
>  
>  	_setup_nvmet
>  
> -	local port
>  	local nvmedev
>  	local size
>  	local bs
>  	local count
>  
> -	truncate -s "${nvme_img_size}" "${def_file_path}"
> -
> -	_create_nvmet_subsystem "${def_subsysnqn}" "${def_file_path}" \
> -		 "${def_subsys_uuid}"
> -	port="$(_create_nvmet_port "${nvme_trtype}")"
> -	_add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}"
> -	_create_nvmet_host "${def_subsysnqn}" "${def_hostnqn}"
> +	_nvmet_target_setup --blkdev=file

I looked back and found that the option above looks wrong. I think it should be
"--blkdev file" instead of "--blkedev=file".

Same for other _nvmet_target_setup calls with the option.


More information about the Linux-nvme mailing list