[PATCH v2] nvmet: force reconnect when number of queue changes

[Knight, Frederick]

Reset and Disconnect are different.

Reset uses registers (and therefore Get Property and Set Property commands) over a valid connection.

Disconnect causes a reset (you have to reconnect to the reset controller)
Reset does not cause an immediate disconnect.

	Fred

> -----Original Message-----
> From: Daniel Wagner <dwagner at suse.de>
> Sent: Wednesday, September 28, 2022 11:26 AM
> To: John Meneghini <jmeneghi at redhat.com>
> Cc: Knight, Frederick <Frederick.Knight at netapp.com>; Sagi Grimberg
> <sagi at grimberg.me>; linux-nvme at lists.infradead.org; Shinichiro Kawasaki
> <shinichiro.kawasaki at wdc.com>; hare at suse.de
> Subject: Re: [PATCH v2] nvmet: force reconnect when number of queue
> changes
> 
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
> 
> 
> 
> 
> On Wed, Sep 28, 2022 at 11:01:00AM -0400, John Meneghini wrote:
> > So this is one place where I think we conflate NVMe-oF with NVMe in
> > the specification.  If "reset" == "disconnect", then Daniel's patches
> > just implemented support for something which is forbidden by the spec
> > - a controller that changes the number of IOQs between resets.
> 
> FWIW, the scenario I described is from a real world experience. So even if it
> is forbidden by the spec, it exists.