[PATCH libnvme 3/1] fabrics: add notify_rediscover parameter

[Daniel Wagner]

On Mon, Sep 12, 2022 at 03:33:15PM +0300, Sagi Grimberg wrote:
> 
> > > @@ -481,6 +482,8 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
> > >   	    (hostid && add_argument(argstr, "hostid", hostid)) ||
> > >   	    (discover && !discovery_nqn &&
> > >   	     add_bool_argument(argstr, "discovery", true)) ||
> > > +	     add_bool_argument(argstr, "notify_rediscover",
> > > +			       cfg->notify_rediscover) ||
> > 
> > If notify_rediscover is not supported by the kernel, wouldn't this end
> > up with an EINVAL when we try to connect? I thought we need to make this
> > conditional.
> 
> The check is done by the callers, which check support for it. If it
> is not supported and still passed, its a bug in the caller.

Okay.

Another thing I was wondering if we might run into a problem with
dependencies on the library via the kernel feature support. But I think
we should be safe and if not, another reason for a 2.x release :)