[PATCH 5/9] nvme-fc: centralize admin tagset initialization

Christoph Hellwig hch at lst.de
Tue Feb 1 00:11:03 PST 2022


On Fri, Jan 28, 2022 at 01:20:11AM -0800, Chaitanya Kulkarni wrote:
> +	nvme_init_admin_tagset(&(ctrl->admin_tag_set), ctrl,

No need for the braceses.

> +			       ctrl->ctrl.numa_node, &nvme_fc_admin_mq_ops,
> +			       BLK_MQ_F_NO_SCHED, NVMF_RESERVED_TAGS);

But do we need all these args?  We should move the admin_tag_sert to the
generic nvme_ctrl and just pass that and the ops.  Everything else
should be same (I hope it currently is, otherwise we need to fix) or
easily derivable (e.g. the check if it is fabrics).

Then mve the helper out of line please and convert all callers in one
patch.




More information about the Linux-nvme mailing list