[PATCH 1/9] nvme-fc: add a helper to initialize connect_q

Christoph Hellwig hch at lst.de
Tue Feb 1 00:09:34 PST 2022


On Fri, Jan 28, 2022 at 01:20:07AM -0800, Chaitanya Kulkarni wrote:
> +static inline int nvme_ctrl_init_connect_q(struct nvme_ctrl *ctrl)
> +{
> +	ctrl->connect_q = blk_mq_init_queue(ctrl->tagset);
> +	if (IS_ERR(ctrl->connect_q))
> +		return PTR_ERR(ctrl->connect_q);
> +	return 0;
> +}

This should be out of line in fabrics.c.

Also I'd prefer one patch to switch everyone to the helper in this
case.



More information about the Linux-nvme mailing list