[PATCH] nvme:core: initialize core quirks before calling nvme_init_subsystem()

[Pankaj Raghav]

On 2022-12-02 10:23, Christoph Hellwig wrote:
> On Thu, Dec 01, 2022 at 01:52:34PM +0100, Pankaj Raghav wrote:
>> A device might have a core quirk for NVME_QUIRK_IGNORE_DEV_SUBNQN(such as
>> Samsung X5) but it would still give a warning "missing or invalid
>> SUBNQN field" as core quirks are filled after calling nvme_init_subnqn().
>>
>> Fill ctrl->quirks from struct core_quirks before calling
>> nvme_init_subsystem().
>>
>> Tested it on a Samsung X5:
> 
> Yes, this looks reasonable.  But it won't help with the CSTS

You are right. I don't think this will help with the CSTS issue, but I
discovered this error message popping up while investigating that issue,
even though I remember the patch you sent that added a quirk to suppress
this message.

> corruption reported by Monish, so it seems like the SSD doesn't actually
> show that issue in all systems?

Yeah, I am not able to reproduce that error in my setup. I am discussing it
with their team to find out the possible root cause.