[PATCH] nvme:core: initialize core quirks before calling nvme_init_subsystem()

Christoph Hellwig hch at lst.de
Fri Dec 2 01:23:22 PST 2022


On Thu, Dec 01, 2022 at 01:52:34PM +0100, Pankaj Raghav wrote:
> A device might have a core quirk for NVME_QUIRK_IGNORE_DEV_SUBNQN(such as
> Samsung X5) but it would still give a warning "missing or invalid
> SUBNQN field" as core quirks are filled after calling nvme_init_subnqn().
> 
> Fill ctrl->quirks from struct core_quirks before calling
> nvme_init_subsystem().
> 
> Tested it on a Samsung X5:

Yes, this looks reasonable.  But it won't help with the CSTS
corruption reported by Monish, so it seems like the SSD doesn't actually
show that issue in all systems?



More information about the Linux-nvme mailing list