[PATCH 3/3] nvme-rdma: assign completion vector correctly

[Christoph Hellwig]

On Wed, Jun 24, 2020 at 11:34:22AM +0300, Max Gurtovoy wrote:
>
> On 6/23/2020 8:34 PM, Sagi Grimberg wrote:
>>
>>>> The completion vector index that is given during CQ creation can't
>>>> exceed the number of support vectors by the underlying RDMA device. This
>>>> violation currently can accure, for example, in case one will try to
>>>> connect with N regular read/write queues and M poll queues and the sum
>>>> of N + M > num_supported_vectors. This will lead to failure in establish
>>>> a connection to remote target. Instead, in that case, share a completion
>>>> vector between queues.
>>>
>>> That sounds like a RC patch? Where is the fixes line? Why is it in
>>> this series?
>>
>> Agree, this should be sent as a separate patch.
>
> The reason I sent it in 1 series is to avoid conflicts. Since all the 
> patches can go to nvme-5.8, I tried to make life easier.
>
> We can do it separately of course.
>
> Christoph,
>
> would you like to merge patches 1+2 from this series or should I send them 
> again as well ?

I don't think 1+2 are 5.8 material, so please just resend 3 standalone
for now, and then resend 1+2 once I've merged it and rebased nvme-5.9
on top of nvme-5.8.