[PATCH 3/3] nvme-rdma: assign completion vector correctly

Max Gurtovoy maxg at mellanox.com
Wed Jun 24 04:34:22 EDT 2020


On 6/23/2020 8:34 PM, Sagi Grimberg wrote:
>
>>> The completion vector index that is given during CQ creation can't
>>> exceed the number of support vectors by the underlying RDMA device. 
>>> This
>>> violation currently can accure, for example, in case one will try to
>>> connect with N regular read/write queues and M poll queues and the sum
>>> of N + M > num_supported_vectors. This will lead to failure in 
>>> establish
>>> a connection to remote target. Instead, in that case, share a 
>>> completion
>>> vector between queues.
>>
>> That sounds like a RC patch? Where is the fixes line? Why is it in
>> this series?
>
> Agree, this should be sent as a separate patch.

The reason I sent it in 1 series is to avoid conflicts. Since all the 
patches can go to nvme-5.8, I tried to make life easier.

We can do it separately of course.

Christoph,

would you like to merge patches 1+2 from this series or should I send 
them again as well ?





More information about the Linux-nvme mailing list