[PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl

[Sagi Grimberg]

>>>> +void nvme_stop_ctrl(struct nvme_ctrl *ctrl)
>>>> +{
>>>> +       __nvme_stop_ctrl(ctrl);
>>>>           nvme_remove_namespaces(ctrl);
>>>> +}
>>>> +EXPORT_SYMBOL_GPL(nvme_stop_ctrl);
>>>
>>> And then this becomes nvme_remove_ctrl?
>>
>> Not a good idea as its not actually removing the controller...
>>
>> Maybe nvme_clear_ctrl?
> 
> Or just call both the new nvme_stop_ctrl and nvme_remove_namespaces
> from each driver.  It's a bit more code, but additional logic..

Yea... I hope we can get it centralize soon so it won't be duplicated.

btw, I think I can unconditionally call nvme_start_queues in
nvme_start_ctrl, the extra unquiesce won't hurt. In fact,
pci does it today. probe calls reset which unconditionally
starts the queues...