[PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl

[Christoph Hellwig]

On Wed, Jul 05, 2017 at 10:04:31PM +0300, Sagi Grimberg wrote:
>>> +void nvme_stop_ctrl(struct nvme_ctrl *ctrl)
>>> +{
>>> +       __nvme_stop_ctrl(ctrl);
>>>          nvme_remove_namespaces(ctrl);
>>> +}
>>> +EXPORT_SYMBOL_GPL(nvme_stop_ctrl);
>>
>> And then this becomes nvme_remove_ctrl?
>
> Not a good idea as its not actually removing the controller...
>
> Maybe nvme_clear_ctrl?

Or just call both the new nvme_stop_ctrl and nvme_remove_namespaces
from each driver.  It's a bit more code, but additional logic..