On Tue, Nov 29, 2016 at 02:52:00PM -0700, Scott Bauer wrote: > + dev = get_or_create_opal_dev(bdev, key->opal_act.key.lr, true); > + if (!dev) > + return -ENOMEM; The alloc_opal_dev from this call returns ERR_PTR values on error, so the check should be: if (IS_ERR_OR_NULL(dev)) return PTR_ERR(dev);