[v4,1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII

Dan Carpenter dan.carpenter at linaro.org
Tue Jan 27 00:55:49 PST 2026


On Mon, Jan 26, 2026 at 04:01:27PM +0000, Simon Horman wrote:
> But at any rate, I think the key question is should the case
> where regmap_write() returns an error be handled in
> s32_gmac_write_phy_intf_select() (by some means)?

Generally if register read/writes fail then there is nothing you
can do a the software level, you need to buy a new computer.  However,
in this case we may eventually put the registers behind an SCMI
interface so probably checking is a good idea.

Could I leave the error message out?  The callers has an error
message and if you ever see the error message, and even with SCMI,
the fix is probably still to buy a new computer.

regards,
dan carpenter



More information about the linux-arm-kernel mailing list