[PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup

Andy Shevchenko andriy.shevchenko at intel.com
Fri Jan 23 00:37:48 PST 2026


On Fri, Jan 23, 2026 at 08:02:48AM +0000, Abdurrahman Hussain via B4 Relay wrote:

> Add a temporary dev variable and reuse it instead of referencing pdev->dev
> everywhere.

...

> -	pm_runtime_enable(i2c->dev);

> +	pm_runtime_enable(dev);

Ah, please also move this to devm_pm_...* in a separate patch or combine it
with mutex and explain that this fixes the cleanup ordering and simplifies
error handling.

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list