[PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup

Andy Shevchenko andriy.shevchenko at intel.com
Fri Jan 23 00:28:07 PST 2026


On Fri, Jan 23, 2026 at 08:02:48AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> 
> Add a temporary dev variable and reuse it instead of referencing pdev->dev
> everywhere.

...

> +	struct device *dev = &pdev->dev;

No, this part should go earlier because of other patches that use it.

devm_clk_get*()
device_get_match_data()

Without this you add an unneeded churn.

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list