[PATCH] stm class: Fix Kconfig symbols
Leo Yan
leo.yan at arm.com
Mon Jan 19 07:46:06 PST 2026
On Mon, Jan 19, 2026 at 12:35:23PM +0000, James Clark wrote:
[...]
> > @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
> > config STM_PROTO_SYS_T
> > tristate "MIPI SyS-T STM framing protocol driver"
> > - default CONFIG_STM
> > + default STM
>
> The help below here says "If you don't know what this is, say N." which
> makes me wonder if this should be on by default or not?
STM_PROTO_BASIC is a must have config when enabling STM. While
STM_PROTO_SYS_T is not mandatory, but it is useful to build it so that
users can select the protocol dynamically at runtime.
> Also everything is in an "if STM" block, so "default STM" is a bit
> redundant. It's not that obvious what the intention was.
They are two different things.
"if STM" expresses a dependency (the module depends on STM), while
"default STM" means the module will be selected by default if STM is
enabled.
Thanks,
Leo
P.s. I also tried using the "select" and "imply" syntax to enable the
protocol configurations. Based on testing, I did not observe any
difference compared to using the "default" syntax.
More information about the linux-arm-kernel
mailing list