[PATCH RFC net-next+ 9/9] net: stmmac: qcom-ethqos: remove phy_set_mode_ext() after phy_power_on()
Mohd Ayaan Anwar
mohd.anwar at oss.qualcomm.com
Mon Feb 23 01:54:15 PST 2026
On Thu, Feb 19, 2026 at 12:51:10PM +0000, Russell King (Oracle) wrote:
> The call to phy_set_mode_ext() after phy_power_on() was a work-around
> for the qcom-sgmii-eth SerDes driver that only re-enabled its clocks on
> phy_power_on() but did not configure the PHY. Now that the SerDes driver
> fully configures the SerDes at phy_power_on(), there is no need to call
> phy_set_mode_ext() immediately afterwards.
>
> This also means we no longer need to record the previous operating mode
> of the driver - this is up to the SerDes driver. In any case, the only
> thing that we care about is the SerDes provides the necessary clocks to
> the stmmac core to allow it to reset at this point. The actual mode is
> irrelevant at this point as the correct mode will be configured in
> ethqos_mac_finish_serdes() just before the network device is brought
> online.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> .../stmicro/stmmac/dwmac-qcom-ethqos.c | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
Reviewed-by: Mohd Ayaan Anwar <mohd.anwar at oss.qualcomm.com>
Ayaan
More information about the linux-arm-kernel
mailing list