[PATCH] cpufreq: mediatek: avoid redundant conditions
Viresh Kumar
viresh.kumar at linaro.org
Wed Sep 3 21:51:07 PDT 2025
On 03-09-25, 20:12, Liao Yuanhong wrote:
> While 'if (i <= 0) ... else if (i > 0) ...' is technically equivalent to
> 'if (i <= 0) ... else ...', the latter is vastly easier to read because
> it avoids writing out a condition that is unnecessary. Let's drop such
> unnecessary conditions.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong at vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index fae062a6431f..00de1166188a 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -123,7 +123,7 @@ static int mtk_cpufreq_voltage_tracking(struct mtk_cpu_dvfs_info *info,
> soc_data->sram_max_volt);
> return ret;
> }
> - } else if (pre_vproc > new_vproc) {
> + } else {
> vproc = max(new_vproc,
> pre_vsram - soc_data->max_volt_shift);
> ret = regulator_set_voltage(proc_reg, vproc,
Applied. Thanks.
--
viresh
More information about the linux-arm-kernel
mailing list