[PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)
William Breathitt Gray
wbg at kernel.org
Thu Jun 20 01:59:07 PDT 2024
On Thu, Jun 20, 2024 at 09:44:51AM +0100, Lee Jones wrote:
> On Wed, 19 Jun 2024, Uwe Kleine-König wrote:
>
> > These two defines have the same purpose and this change doesn't
> > introduce any differences in drivers/counter/stm32-timer-cnt.o.
> >
> > The only difference between the two is that
> >
> > TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE
> >
> > while
> >
> > TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE
> >
> > . That makes it necessary to have an explicit "+ 1" in the user code,
> > but IMHO this is a good thing as this is the code locatation that
> > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE
> > (because software guys start counting at 0, while the relevant hardware
> > designer started at 1).
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
> > ---
> > drivers/counter/stm32-timer-cnt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Did you drop William's Ack on purpose?
>
> --
> Lee Jones [李琼斯]
No problem, here it is again for the sake of the LKML scraper tools:
Acked-by: William Breathitt Gray <wbg at kernel.org>
Lee, do you prefer taking this patchset through your tree?
William Breathitt Gray
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240620/97306e22/attachment.sig>
More information about the linux-arm-kernel
mailing list