[PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)
Lee Jones
lee at kernel.org
Thu Jun 20 01:44:51 PDT 2024
On Wed, 19 Jun 2024, Uwe Kleine-König wrote:
> These two defines have the same purpose and this change doesn't
> introduce any differences in drivers/counter/stm32-timer-cnt.o.
>
> The only difference between the two is that
>
> TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE
>
> while
>
> TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE
>
> . That makes it necessary to have an explicit "+ 1" in the user code,
> but IMHO this is a good thing as this is the code locatation that
> "knows" that for software channel 1 you have to use TIM_DIER_CC2IE
> (because software guys start counting at 0, while the relevant hardware
> designer started at 1).
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
> ---
> drivers/counter/stm32-timer-cnt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Did you drop William's Ack on purpose?
--
Lee Jones [李琼斯]
More information about the linux-arm-kernel
mailing list