[PATCH] driver: soc: xilinx: Convert to platform remove callback returning void

Michal Simek michal.simek at amd.com
Mon Jul 24 09:01:33 PDT 2023



On 7/24/23 17:44, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Jul 24, 2023 at 09:56:19AM +0200, Uwe Kleine-König wrote:
>> The .remove() callback for a platform driver returns an int which makes
>> many driver authors wrongly assume it's possible to do error handling by
>> returning an error code. However the value returned is (mostly) ignored
>> and this typically results in resource leaks. To improve here there is a
>> quest to make the remove callback return void. In the first step of this
>> quest all drivers are converted to .remove_new() which already returns
>> void.
>>
>> The Xilinx Event Management driver can return a non-zero value, but in
>> this case already emitted an error message. So the only side effect of
>> converting to .remove_new is to suppress a duplictated error message.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> hmm, I already sent this patch before (with a slightly different
> wording)[1] and Michal Simek already claimed to have applied it.
> Sorry for the duplicate.

It is here.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/soc/xilinx/xlnx_event_manager.c?h=next-20230724&id=e88640651ed42c76336dc21f080dca63244cdcff

M



More information about the linux-arm-kernel mailing list