[PATCH] driver: soc: xilinx: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Jul 24 08:44:54 PDT 2023


Hello,

On Mon, Jul 24, 2023 at 09:56:19AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> The Xilinx Event Management driver can return a non-zero value, but in
> this case already emitted an error message. So the only side effect of
> converting to .remove_new is to suppress a duplictated error message.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

hmm, I already sent this patch before (with a slightly different
wording)[1] and Michal Simek already claimed to have applied it.
Sorry for the duplicate.

Best regards
Uwe

[1] https://lore.kernel.org/all/818a76e7-0085-1d1b-481e-eb22d9d4380b@amd.com
-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230724/0822a721/attachment.sig>


More information about the linux-arm-kernel mailing list