[PATCH 0/5] pwm: atmel-tcb: Some driver maintenance
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Wed Jul 19 12:20:08 PDT 2023
Hello,
here come some improvements to the pwm-atmel-tcb driver.
There are still a few opportunities to improve the driver. For example
.duty shouldn't be relevant for atmel_tcb_pwm_disable(). Also the driver
could be converted from of_clk_get_by_name to devm_clk_get() (and then
also devm_pwmchip_add()). Further more I think all members of
atmel_tcb_pwm_device could be dropped as they are all only used in
.apply() after they were assigned earlier in the same function; similar
to how I removed the polarity member. Maybe someone with the hardware
wants to chime in?
Best regards
Uwe
Uwe Kleine-König (5):
pwm: atmel-tcb: Harmonize resource allocation order
pwm: atmel-tcb: Fix resource freeing in error path and remove
pwm: atmel-tcb: Put per-channel data into driver data
pwm: atmel-tcb: Unroll atmel_tcb_pwm_set_polarity() into only caller
pwm: atmel-tcb: Don't track polarity in driver data
drivers/pwm/pwm-atmel-tcb.c | 120 ++++++++++++++----------------------
1 file changed, 47 insertions(+), 73 deletions(-)
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
--
2.39.2
More information about the linux-arm-kernel
mailing list