[PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port

[Paul Kocialkowski]

Hi Laurent,

On Sat 27 Aug 22, 01:29, Laurent Pinchart wrote:
> Hi Paul,
> 
> Thank you for the patch.

Thanks for the review!

> On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote:
> > Some Allwinner devices come with an Image Signal Processor (ISP) that
> > allows processing camera data to produce good-looking images,
> > especially from raw bayer representations.
> > 
> > The ISP does not have a dedicated capture path: it is fed directly by
> > one of the CSI controllers, which can be selected at run-time.
> > 
> > Represent this possibility as a graph connection between the CSI
> > controller and the ISP in the device-tree bindings.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
> > Acked-by: Rob Herring <robh at kernel.org>
> > ---
> >  .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml    | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > index 8551c4a711dc..54eb80e517e3 100644
> > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > @@ -73,6 +73,10 @@ properties:
> >          $ref: /schemas/graph.yaml#/properties/port
> >          description: MIPI CSI-2 bridge input port
> >  
> > +      port at 2:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: ISP output port
> > +
> 
> I'd write "Output port to the ISP" to make it clearer.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Agreed, thanks!

Paul

> >      anyOf:
> >        - required:
> >            - port at 0
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20220901/c6a458b4/attachment.sig>