[PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option

Fabio Estevam festevam at gmail.com
Thu May 13 12:51:17 PDT 2021


Hi Alexander,

On Thu, May 13, 2021 at 12:12 PM Alexander Shiyan <shc_work at mail.ru> wrote:
>
> On Tue, 11 May 2021 10:37:50 +0800
> Shawn Guo <shawnguo at kernel.org> wrote:
>
> These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
> so AC97 parameters are not used in such cases.

Looking at imx6qdl-icore-rqs.dtsi, I see it uses the sgtl5000 audio codec.

To make the commit log clearer, you could also state that the board
uses the sgtl5000 codec connected via I2S.
Then it would become easier to understand why 'fsl,mode' could be removed.

Reviewed-by: Fabio Estevam <festevam at gmail.com>



More information about the linux-arm-kernel mailing list