[PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option

Alexander Shiyan shc_work at mail.ru
Thu May 13 08:12:16 PDT 2021


On Tue, 11 May 2021 10:37:50 +0800
Shawn Guo <shawnguo at kernel.org> wrote:

These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
so AC97 parameters are not used in such cases.

> On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote:
> > The operating mode is used for the AC97 interface only,
> > so lets drop the excess fsl,mode item from SSI node.
> 
> Isn't it 'fsl,mode' meant for?  I do not follow how it becomes excess.
> 
> - fsl,mode:         The operating mode for the AC97 interface only.
>                     "ac97-slave" - AC97 mode, SSI is clock slave
>                     "ac97-master" - AC97 mode, SSI is clock master
> 
> Shawn
> 
> > 
> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> > ---
> >  arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > index a4217f564a53..67b2dd510981 100644
> > --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > @@ -225,7 +225,6 @@ &pcie {
> >  };
> >  
> >  &ssi1 {
> > -	fsl,mode = "i2s-slave";
> >  	status = "okay";
> >  };
> >  
> > -- 
> > 2.26.2
> > 


-- 
Alexander Shiyan <shc_work at mail.ru>



More information about the linux-arm-kernel mailing list