[PATCH v7 05/10] ARM: irqchip: mxs: add Alpascale ASM9260 support

Thomas Gleixner tglx at linutronix.de
Tue Oct 21 00:27:27 PDT 2014


On Tue, 21 Oct 2014, Oleksij Rempel wrote:
>  static void icoll_unmask_irq(struct irq_data *d)
>  {
> -	__raw_writel(BM_ICOLL_INTR_ENABLE,
> -			icoll_priv.intr + SET_REG + HW_ICOLL_INTERRUPTn(d->hwirq));
> +	mutex_lock(&icoll_lock);

And how's that supposed to work? You certainly did not run this code
with even the simplest debugging options enabled. Not to talk about
lockdep or such.

Thanks,

	tglx



More information about the linux-arm-kernel mailing list