[PATCH 4/4] ARM: add 32bit support to GICv3

Jean-Philippe Brucker Jean-Philippe.Brucker at arm.com
Thu Dec 11 08:57:11 PST 2014


On Thu, Dec 11, 2014 at 03:40:31PM +0000, Marc Zyngier wrote:
> On 11/12/14 14:32, Russell King - ARM Linux wrote:
> > On Thu, Dec 11, 2014 at 02:23:08PM +0000, Jean-Philippe Brucker wrote:
> >> +#ifndef __ASM_ARCH_GICV3_H
> >> +#define __ASM_ARCH_GICV3_H
> >> +
> >> +#ifndef __ASSEMBLY__
> >> +
> >> +#include <asm/io.h>
> > 
> > This should be linux/io.h
> 
> Also, you should probably move the #ifndef down to the level of the
> inline functions. The #defines are perfectly usable in assembly context.
> 

This would require a change in the definition of __ACCESS_CP15, in order
to distinguish between inlined parameter '%0' and explicit registers.
I don't see any pleasant ways to do this, apart from adding a 'reg'
argument to all those #defines.
Furthermore, all other cp15 accesses from assembly on the arm/ side seem
to use raw opcodes, instead of macro names.

Thanks,
Jean




More information about the linux-arm-kernel mailing list