[PATCH 4/4] ARM: add 32bit support to GICv3

Marc Zyngier marc.zyngier at arm.com
Thu Dec 11 07:40:31 PST 2014


On 11/12/14 14:32, Russell King - ARM Linux wrote:
> On Thu, Dec 11, 2014 at 02:23:08PM +0000, Jean-Philippe Brucker wrote:
>> +#ifndef __ASM_ARCH_GICV3_H
>> +#define __ASM_ARCH_GICV3_H
>> +
>> +#ifndef __ASSEMBLY__
>> +
>> +#include <asm/io.h>
> 
> This should be linux/io.h

Also, you should probably move the #ifndef down to the level of the
inline functions. The #defines are perfectly usable in assembly context.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...



More information about the linux-arm-kernel mailing list