Adding a void * to pinctrl_pin_desc

Linus Walleij linus.walleij at linaro.org
Mon Apr 29 08:21:15 EDT 2013


On Sat, Apr 27, 2013 at 2:54 AM, Sherman Yin <syin at broadcom.com> wrote:
> [Me]
>> Then use container_of() to dereference a struct foo_pin_desc pointer from
>> the
>> pointer at &foodesc->desc;
>
> Hmm, while it would be easy to create a macro to fill the static foo_pin_desc array
> in the driver, this array would not be suitable for use with pinctrl_register().

Now I start to change opinion. You're right about this.

> I would have to, in the probe function, loop through the foo_pin_desc array and
> create another pinctrl_pin_desc array to use for pinctrl_desc.pins.

Yeah that sucks.

> I think I'll just use a separate struct in the driver to keep track of other pin-specific data.

No I think I have changed opinion. Can you send a patch adding a void * to
struct pinctrl_pin_desc  as patch [1/n] when you send your driver, and
I think I'll be happy with it.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list