[PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Mon Apr 22 09:34:05 EDT 2013


Hello.

On 22-04-2013 5:09, Simon Horman wrote:

>>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and
>>> registered in the Marzen board file.  Move the data and code to their proper
>>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[]
>>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered
>>
>>      I've been pointed to the types in the above variable names privately.
>> Don't know should I resend or Simon could fix s/8a7779/r8a7779/ while
>> applying... well, the USB patches haven't been ACK'ed yet.

> I can fix that up.

> Is the series waiting on anything?

    Probably on Felipe's ACKs on rcar-phy.c patches... Felipe hasn't appeared 
on this list for a week but I see his mails from today.

>> >from r8a7779_add_standard_devices() anyway.

>>> Note that I'm deliberately changing the USB PHY platform device's 'id' field
>> >from (previously just omitted) 0 to -1 as the device is a single of its kind.

>>> Note also that the board and SoC code have to be in one patch to keep the code
>>> bisectable...

>>> The patch has been tested on the Marzen board.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>>> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>>> Acked-by: Simon Horman <horms+renesas at verge.net.au>

WBR, Sergei




More information about the linux-arm-kernel mailing list