[PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

Simon Horman horms at verge.net.au
Sun Apr 21 23:45:54 EDT 2013


On Fri, Apr 19, 2013 at 03:44:46PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 19-04-2013 6:17, Simon Horman wrote:
> 
> >>>>+/* USB PHY */
> >>>>+static struct resource usb_phy_resources[] = {
> >>>>+	[0] = {
> >>>>+		.start		= 0xffe70000,
> >>>>+		.end		= 0xffe70900 - 1,
> >>>>+		.flags		= IORESOURCE_MEM,
> >>>>+	},
> >>>>+	[1] = {
> >>>>+		.start		= 0xfff70000,
> >>>>+		.end		= 0xfff70900 - 1,
> >>>>+		.flags		= IORESOURCE_MEM,
> >>>>+	},
> 
> >>>Please consider using the macros for these initialisers.
> 
> >>    I'm just moving the code as is here. The destination file still
> >>uses old style initializers, and probably needs the wholesale
> >>conversion patch in the future.
> 
> >My preference is for you to either convert these users in this patch or
> >provide a patch that makes a wholesale conversion.
> 
>    I'll try to do the latter but my load is currently very high, so that
> may take some time.

Thanks. In the same vein I have posted the following patch to
convert the sh73a0 SoC to use the macros.

"[PATCH] ARM: shmobile: sh73a0: Use IORESOURCE_MEM_* everywhere"



More information about the linux-arm-kernel mailing list