[PATCH v3] ARM: default machine descriptor for multiplatform

Rob Herring robherring2 at gmail.com
Fri Apr 19 18:22:15 EDT 2013


On 04/19/2013 04:54 PM, Arnd Bergmann wrote:
> On Friday 19 April 2013, Rob Herring wrote:
>> This will fail to build for !OF. of_platform.h needs this:
>>
>> #define of_default_bus_match_table NULL
>>
>> You may need some struct forward declarations, but this commit in my
>> tree for 3.10 should fix those:
>>
>> commit d450f445f9a654080a6be4094376c2192d9a1f36
>> Author: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>> Date:   Tue Feb 19 02:58:25 2013 +0300
>>
>>     <linux/of_platform.h>: fix compilation warnings with DT disabled
>>
> 
> Ok. I've actually stumbled over missing declarations from of_platform.h
> and related files a number of times. Could we please not hide any
> declarations inside of #ifdef when there is no #else alternative?
> 
> If we just show the of_default_bus_match_table declaration in the
> header file, there is no need to provide the silly NULL macro,
> since the of_platform_populate alternative will just ignore it.
> 
> I'll just put the code in an #ifdef for now, but I'd really prefer
> to clean up this and many other locations that currently have
> to do #ifdef CONFIG_OF when they really don't need to.

I think we can kill off CONFIG_OF_DEVICE completely. It is always
enabled when OF is (even for the oddball Sparc).

The only remaining user of of_platform_driver is ibmebus and 2 drivers.
It would be good to convert those to regular platform drivers.

Rob




More information about the linux-arm-kernel mailing list