[PATCH v2 1/4] imx-drm: parallel-display: Fix valid_mode checking

Rogerio Pimentel rogerio.pimentel at freescale.com
Tue Apr 9 10:07:29 EDT 2013


It fixes the logic of valid_mode checking, it's now
in accordance with drm_mode_status enumeration.

Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Signed-off-by: Rogerio Pimentel <rogerio.pimentel at freescale.com>
---
Changes since v1:
Removed the "if(np)" block and now using the existent functions to get
the modes by fixing the mode_valid logic test 
 drivers/staging/imx-drm/parallel-display.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c
index a8064fc..49c90c3 100644
--- a/drivers/staging/imx-drm/parallel-display.c
+++ b/drivers/staging/imx-drm/parallel-display.c
@@ -64,7 +64,7 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 	}
 
-	if (imxpd->mode_valid) {
+	if (imxpd->mode_valid == MODE_OK) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		drm_mode_copy(mode, &imxpd->mode);
 		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
@@ -78,7 +78,7 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 static int imx_pd_connector_mode_valid(struct drm_connector *connector,
 			  struct drm_display_mode *mode)
 {
-	return 0;
+	return MODE_OK;
 }
 
 static struct drm_encoder *imx_pd_connector_best_encoder(
-- 
1.7.10.4





More information about the linux-arm-kernel mailing list