[PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Apr 9 10:07:58 EDT 2013


Hi Linus,

On Tuesday 09 April 2013 10:06:45 Linus Walleij wrote:
> On Tue, Mar 26, 2013 at 4:23 PM, Laurent Pinchart wrote:
> >> About this issue, the fact that selecting PINCTRL without GPIO results
> >> in compile error makes me think that something needs slight adjustment
> >> in the PFC code.
> > 
> > The above errors come from the pinctrl core (although the PFC driver might
> > not compile either in this case). Linus, what's your opinion on this ? Do
> > we want to support systems with pinctrl but without gpiolib ?
> 
> Yes. It is perfectly legal to have pin controllers that do not correlate
> GPIO ranges.
> 
> Does commit 2afe8229687ec24cbc07e78449a588bb8b68f858
> "pinctrl: core: add dependence of GPIOLIB"
> by Haojian fix this issue?

Yes it does.

I've just sent a patch that makes GPIOLIB support optional in the PFC driver. 
Magnus, with these two, should we revert 
6722f6cb763203cab775297b6e9d00834af0d6d7 ?

-- 
Regards,

Laurent Pinchart




More information about the linux-arm-kernel mailing list