[PATCH] i2c: mxs: disable QUEUE when sending is done
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Sat Apr 28 06:26:01 EDT 2012
On Fri, Apr 27, 2012 at 11:51:56AM -0300, Fabio Estevam wrote:
> Hi Wolfram,
>
> On Fri, Apr 27, 2012 at 11:23 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
>
> > if (i2c->cmd_err == -ENXIO)
> > mxs_i2c_reset(i2c);
> > + else
> > + writel(MXS_I2C_QUEUECTRL_QUEUE_RUN,
> > + i2c->regs + MXS_I2C_QUEUECTRL_CLR);
>
> When setting the QUEUE_RUN, do we really want to clear all the other
> bits of QUEUECTRL_CLR register?
>
> I am wondering if we should only set QUEUE_RUN bit here.
I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR
just clears the QUEUE_RUN bit and nothing else?!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list