[PATCH] i2c: mxs: disable QUEUE when sending is done

Fabio Estevam festevam at gmail.com
Fri Apr 27 10:51:56 EDT 2012


Hi Wolfram,

On Fri, Apr 27, 2012 at 11:23 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:

>        if (i2c->cmd_err == -ENXIO)
>                mxs_i2c_reset(i2c);
> +       else
> +               writel(MXS_I2C_QUEUECTRL_QUEUE_RUN,
> +                               i2c->regs + MXS_I2C_QUEUECTRL_CLR);

When setting the QUEUE_RUN, do we really want to clear all the other
bits of QUEUECTRL_CLR register?

I am wondering if we should only set QUEUE_RUN bit here.

My mx28evk does not come with i2c eeprom. I hope I will solder one
soon so I can test it.

Thanks,

Fabio Estevam



More information about the linux-arm-kernel mailing list