No subject


Fri Nov 6 13:01:15 EST 2009


> From: Sascha Hauer <s.hauer at pengutronix.de>
> Date: Mon, 30 Nov 2009 13:31:29 +0100
> Subject: [PATCH] i.MX27 audmux: Fix register offsets
>
> The PPCR registers start at 0x10, not 0xc. Fix this.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  arch/arm/plat-mxc/include/mach/audmux.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/audmux.h
> b/arch/arm/plat-mxc/include/mach/audmux.h
> index 5cd6466..dcc12d4 100644
> --- a/arch/arm/plat-mxc/include/mach/audmux.h
> +++ b/arch/arm/plat-mxc/include/mach/audmux.h
> @@ -4,9 +4,9 @@
>  #define MX27_AUDMUX_HPCR1_SSI0         0
>  #define MX27_AUDMUX_HPCR2_SSI1         1
>  #define MX27_AUDMUX_HPCR3_SSI_PINS_4   2
> -#define MX27_AUDMUX_PPCR1_SSI_PINS_1   3
> -#define MX27_AUDMUX_PPCR2_SSI_PINS_2   4
> -#define MX27_AUDMUX_PPCR3_SSI_PINS_3   5
> +#define MX27_AUDMUX_PPCR1_SSI_PINS_1   4
> +#define MX27_AUDMUX_PPCR2_SSI_PINS_2   5
> +#define MX27_AUDMUX_PPCR3_SSI_PINS_3   6
>

Be careful,
I think this patch breaks some of the boards currently using
MXC_AUDMUX_V1_PCR_RXDSEL(x) and similar macros defined in mach/audmux.h (for
example pcm038).
For those macros the old AUDMUX register indexes are fine.

I suggest fixing this inside audmux_v1.c instead of modifying mach/audmux.h.


Thank you.
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com

--0016e6d58cb2408bb9047996596d
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable



More information about the linux-arm-kernel mailing list