[PATCH] afs: fix tracepoint string placement with built-in AFS
Steven Rostedt
rostedt at goodmis.org
Thu Jun 17 06:37:12 PDT 2021
On Thu, 17 Jun 2021 13:04:49 +0100
David Howells <dhowells at redhat.com> wrote:
> Steven Rostedt <rostedt at goodmis.org> wrote:
>
> > Looks fine to me, and even saves 4 bytes on 64 bit machines (events are
> > rounded up to 4 byte increments, so the u16 is no different than a u32
> > here).
>
> Can I put that down as a Reviewed-by?
Sure. I was going to recommend consolidating the mappings a bit more to
have the enums and numbers defined in a single macro, but then I saw that
it matches the rest of the header file, and to do the consolidation would
require modifying the existing code, which I thought wasn't worth the
effort.
Reviewed-by: Steven Rostedt (VMware) <rostedt at goodmis.org>
-- Steve
More information about the linux-afs
mailing list