[PATCH 1/2] fix indentation.

Alexander Nickulin anikulin at dlink.ru
Mon Dec 7 04:16:21 EST 2020


> On Fri,  4 Dec 2020 17:40:27 +0300
> Alexander Nickulin <anikulin at dlink.ru> wrote:
> 
> > diff --git a/lib/netfilter/exp.c b/lib/netfilter/exp.c
> > index 9cfdd2b..15d6fb7 100644
> > --- a/lib/netfilter/exp.c
> > +++ b/lib/netfilter/exp.c
> > @@ -350,10 +350,10 @@ static int nfnl_exp_build_tuple(struct nl_msg
> > *msg, const struct nfnl_exp *exp, 
> >  	int type = exp_get_tuple_attr(cta);
> >  
> > -    if (cta == CTA_EXPECT_NAT)
> > -        tuple = nla_nest_start(msg, CTA_EXPECT_NAT_TUPLE);
> > -    else
> > -        tuple = nla_nest_start(msg, cta);
> > +	if (cta == CTA_EXPECT_NAT)  
> 
> You are replacing spaces with tabs there. Not sure which coding style
> is preferred in this project, but I guess you should follow the style
> already used, which from looking at your patch's included context only
> appears to be of the four-spaces persuasion and not tab characters.
> 
> 
> Kind regards,
>      jer

I see the tabs (0x09) exactly around there used as indentations but no
"4-spaces" (0x20 0x20 0x20 0x20) style.

BR.
A.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: Цифровая подпись OpenPGP
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20201207/985be7b5/attachment.sig>


More information about the libnl mailing list